Add security permission for temporary directory#105
Merged
Conversation
Add sync_permissions method to ClaudeAdapter that automatically adds Read, Edit, and Write permissions for .deepwork/tmp/** to settings.json. This is called during the sync process (which runs during install) to ensure DeepWork has unrestricted access to its temporary directory. - Add sync_permissions() to AgentAdapter base class with default no-op - Implement sync_permissions() in ClaudeAdapter to add .deepwork/tmp/** - Call sync_permissions from sync_skills() after syncing hooks - Add unit tests for permission syncing
- Fix permission path syntax to use ./ prefix per Claude Code docs (e.g., Read(./.deepwork/tmp/**) instead of Read(.deepwork/tmp/**)) - Refactor ClaudeAdapter with reusable _load_settings, _save_settings, and add_permission methods for cleaner permission management - Add add_skill_permissions method that adds Skill(name) permissions for each generated skill during sync, allowing Claude to invoke skills without permission prompts - Update sync.py to collect skill paths and call add_skill_permissions - Add comprehensive unit tests for new permission methods
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sync_permissions method to ClaudeAdapter that automatically adds Read, Edit, and Write permissions for .deepwork/tmp/** to settings.json. This is called during the sync process (which runs during install) to ensure DeepWork has unrestricted access to its temporary directory.